Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58468 )
Change subject: Makefile, ich_descriptors_tool/Makefile: unify behavior ......................................................................
Patch Set 3:
(7 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58468/comment/9be0a697_9179f5d2 PS2, Line 7: descriptor
nit: missing plural `s` in `descriptors`
Done
https://review.coreboot.org/c/flashrom/+/58468/comment/baeebb51_5460b001 PS2, Line 9: remove
use gerund form: `removing`
Done
https://review.coreboot.org/c/flashrom/+/58468/comment/a3f8a67a_4deb6c85 PS2, Line 12: descriptor
nit: missing plural `s` in `descriptors`
Done
https://review.coreboot.org/c/flashrom/+/58468/comment/84bdffea_a5bbf48b PS2, Line 13: Makefie
typo: missing `l` in `Makefile`
Done
https://review.coreboot.org/c/flashrom/+/58468/comment/79b9cb47_103fded5 PS2, Line 16: set CFLAGS and EXEC_SUFFIX for TARGET_OS not for the HOST_OS
Two nits: […]
Done
https://review.coreboot.org/c/flashrom/+/58468/comment/6bdac599_40f40b2f PS2, Line 19: descriptor
nit: missing plural `s` in `descriptors`
Done
File util/ich_descriptors_tool/Makefile:
https://review.coreboot.org/c/flashrom/+/58468/comment/1c6daba0_f558cac1 PS2, Line 42: */
nit: remove?
Done