Attention is currently required from: Nico Huber, Angel Pons, Patrick Rudolph. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55353 )
Change subject: flashchips: Add support for Macronix MX66L1G45G ......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55353/comment/3453f265_c98bdf2d PS1, Line 7: MACRONIX
nit: `Macronix`
Done
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/55353/comment/af165c44_48d228f8 PS1, Line 10075: },
nit: flashchip entries are separated by a blank line
Done
https://review.coreboot.org/c/flashrom/+/55353/comment/3a6695fc_07b61b19 PS1, Line 10078: MACRONIX_
Drop this prefix?
Done
https://review.coreboot.org/c/flashrom/+/55353/comment/2ec6b629_f0b46336 PS1, Line 10117: MX25L12835F
Hmmmmm... […]
Done
https://review.coreboot.org/c/flashrom/+/55353/comment/33c9cb1f_b1ea1b5f PS1, Line 10123: },
same here, flashchip entries are separated by a blank line
Done