4 Oct
2020
4 Oct
'20
11:15 p.m.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44776 )
Change subject: dediprog: Disable SPI_MASTER_NO_4BA_MODES for additional devices ......................................................................
Patch Set 2: Code-Review+2
Perhaps it will be cleaner to enable 4BA in both native instruction mode and extended address mode by default, and then disallow it for older devices/FW revisions.
In any case, this helps get users past an annoying error, so LGTM.
--
To view, visit https://review.coreboot.org/c/flashrom/+/44776
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iee0ba972245b9317ef86345432fec5fc32614888
Gerrit-Change-Number: 44776
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 04 Oct 2020 23:15:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment