Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Joursoir.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64351 )
Change subject: cli_classic: fix memory leak
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Should I add this to the commit message, or is it just the message to anyone?
It's just a message to help everyone finding the cause for this patch.
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/64351/comment/b5eb2628_1e574829
PS1, Line 1103: if (set_wp_region && wp_region)
Theoretically, yes. If pointer is a null-pointer, no action would occur. […]
The standard says: `If ptr is a null pointer, no action occurs.`
- C99 standard (ISO/IEC 9899:1999); 7.20.3.2 The free function
But I'm not sure how we handle it here.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64351
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe
Gerrit-Change-Number: 64351
Gerrit-PatchSet: 1
Gerrit-Owner: Joursoir
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Joursoir
chat@joursoir.net
Gerrit-Comment-Date: Mon, 16 May 2022 08:43:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Joursoir
chat@joursoir.net
Gerrit-MessageType: comment