Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45461 )
Change subject: dummyflasher.c: Upstream ChromiumOS 'freq' param feature
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/flashrom/+/45461/1/dummyflasher.c
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/45461/1/dummyflasher.c@297
PS1, Line 297: tmp
I don't see this use of tmp being freed anywhere.
Agreed, typical cros fork seems buggy here so fixed those leaks now.
https://review.coreboot.org/c/flashrom/+/45461/1/dummyflasher.c@308
PS1, Line 308: goto dummy_init_out;
Should this be return 1 like the other error case?
yes.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/45461
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1c2702b9e0cae860f5f03114e307707d4d3219af
Gerrit-Change-Number: 45461
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Namyoon Woo
namyoon@google.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 17 Sep 2020 05:20:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally
sammc@google.com
Gerrit-MessageType: comment