Attention is currently required from: Nico Huber, Subrata Banik, Paul Menzel, Edward O'Callaghan, Angel Pons. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62867 )
Change subject: ichspi: Unify timeouts across all SPI operations to 30s ......................................................................
Patch Set 8:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62867/comment/6ab39b98_320eb32d PS7, Line 7: Unify timeout (30sec) across all SPI operations
`Unify timeouts across all SPI operations to 30s`
Ack
https://review.coreboot.org/c/flashrom/+/62867/comment/5a571279_ff4276d2 PS7, Line 9: This patch removes taking `timeout` argument for different operations : using `ich_hwseq_wait_for_cycle_complete()`. Make use of 30sec unified : timeout for all SPI operations.
Ack
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62867/comment/9b7f44c7_15fb95f0 PS7, Line 31: multi-master accessing the
`multi-mastering access of the`
Ack
https://review.coreboot.org/c/flashrom/+/62867/comment/9b25e11a_2bd69196 PS7, Line 31: might
`may`
Ack
https://review.coreboot.org/c/flashrom/+/62867/comment/279839e7_a4627f4d PS7, Line 36: it's impossible to know : * the actual status of the SPI bus
I thought that is the point of the `HSFS_SCIP` bit? The phrasing may need adjustment here to clarify […]
Done