4 Mar
2019
4 Mar
'19
3:13 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31068 )
Change subject: Fix erasing of unaligned regions ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31068/3/flashrom.c File flashrom.c:
https://review.coreboot.org/#/c/31068/3/flashrom.c@1806 PS3, Line 1806: free(erased_contents); since flashrom is building on everything under the sun: there are systems that strongly dislike free(NULL), so guard it? (for example, Solaris IIRC)
--
To view, visit https://review.coreboot.org/c/flashrom/+/31068
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5fc35310f0b090f218cd1d660e27fb39dd05c3c5
Gerrit-Change-Number: 31068
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-Comment-Date: Mon, 04 Mar 2019 14:13:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment