24 Jun
2021
24 Jun
'21
1:26 a.m.
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Daniel Campello. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33542 )
Change subject: layout: Introduce layout_next() ......................................................................
Patch Set 7:
(1 comment)
File layout.c:
https://review.coreboot.org/c/flashrom/+/33542/comment/08d90312_f8d45876 PS7, Line 319: /* Validate and - if needed - normalize layout entries. */ : int normalize_romentries(const struct flashctx *flash)
Sorry I've only noticed now, but how this function is doing normalization? I see it is doing validat […]
I found it later in the chain CB:54285
--
To view, visit https://review.coreboot.org/c/flashrom/+/33542
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I284958471c61344d29d92c95d88475065a9ca9aa
Gerrit-Change-Number: 33542
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Daniel Campello campello@chromium.org
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Daniel Campello campello@chromium.org
Gerrit-Comment-Date: Thu, 24 Jun 2021 01:26:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment