Attention is currently required from: Felix Singer, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67074 )
Change subject: flashrom.c: Make 'chip_to_probe' a param to probe_flash()
......................................................................
Patch Set 1:
(1 comment)
File include/flash.h:
https://review.coreboot.org/c/flashrom/+/67074/comment/6d60b7b4_f988d953
PS1, Line 326: const char *chip_to_probe; /* workaround for probe_w29ee011(). */
The alternative ending has been prepared at CB:67091
I have reviewed an alternative ending and then I discovered this one :) Is this one still needed or are you switching to alternative ending (the latter is a part of the larger chain)?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67074
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I22a6c610e3f3c5a26898d4bbfafbb4df3c07ef6e
Gerrit-Change-Number: 67074
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Fri, 09 Sep 2022 09:04:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment