3 Nov
2022
3 Nov
'22
10:41 p.m.
Attention is currently required from: Subrata Banik, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69129 )
Change subject: writeprotect,ichspi,spi25: handle register access constraints ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/69129/comment/57fea6a4_41aa5bcf PS1, Line 1398: SPI_INVALID_OPCODE
This isn't a SPI master so we should technically return something else, but it makes things more con […]
Add a code comment.
--
To view, visit https://review.coreboot.org/c/flashrom/+/69129
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2145749dcc51f4556550650dab5aa1049f879c45
Gerrit-Change-Number: 69129
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Thu, 03 Nov 2022 22:41:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nikolai Artemiev nartemiev@google.com
Gerrit-MessageType: comment