13 Oct
2021
13 Oct
'21
2:03 p.m.
Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58269 )
Change subject: Makefile: move architecture determination test into the Makefile ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: Roughly the same as in the parent commit, what you add to `Makefile.include` could instead be a separate file, e.g. `make-tests/arch.h`. IMHO, that's much easier to handle than longer C-code parts in the Makefile.
--
To view, visit https://review.coreboot.org/c/flashrom/+/58269
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I29ce73be9c5cbe259a2471f8eea2f8745b68cdfa
Gerrit-Change-Number: 58269
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 13 Oct 2021 14:03:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment