David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38919 )
Change subject: Add support for Fudan SPI flash chips
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
I just checked the datasheets and the JEDEC spec as well and I think James is correct about the manufacturer ID. Otherwise this looks good!
https://review.coreboot.org/c/flashrom/+/38919/1/flashchips.h
File flashchips.h:
https://review.coreboot.org/c/flashrom/+/38919/1/flashchips.h@333
PS1, Line 333: #define FUDAN_ID_NOPREFIX 0x04 /* Fudan, missing 0x7F prefix */
This should be A1, according to the datasheets (I'm looking at FM25Q32 and FM25F005) and JEP106.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/38919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I11dd82f8c4003cc6f974981cb92dca084f1df1f0
Gerrit-Change-Number: 38919
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: James
jye836@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 23 Feb 2020 19:27:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment