9 Apr
2020
9 Apr
'20
1:30 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 )
Change subject: flashchips: support Winbond W25Q64JW ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Looks good, thank you! One small nit in the commit message, though.
Note that flashrom loses the "Verified" score when editing the commit message. To make Jenkins run again, you can trigger a rebase (there's a button on Gerrit, around the top right corner).
https://review.coreboot.org/c/flashrom/+/40275/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/40275/5//COMMIT_MSG@7 PS5, Line 7: support Add support for
--
To view, visit https://review.coreboot.org/c/flashrom/+/40275
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967
Gerrit-Change-Number: 40275
Gerrit-PatchSet: 5
Gerrit-Owner: Scott Chao scott.chao@bitland.corp-partner.google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Casper Chang casper.chang@bitland.corp-partner.google.com
Gerrit-CC: Paul Ma magf@bitland.com.cn
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Apr 2020 13:30:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment