15 Jul
2021
15 Jul
'21
6:37 p.m.
Attention is currently required from: Nico Huber, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56323 )
Change subject: tests: Wrap strdup to help cmocka recognise memory allocation ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/56323/comment/ef850e78_055b76df PS1, Line 34: char *__wrap_strdup(const char *s) Maybe add a comment referencing the cmocka issue?
/* Workaround for https://github.com/clibs/cmocka/issues/17 */
--
To view, visit https://review.coreboot.org/c/flashrom/+/56323
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I56aef6b342752d80995c36ab075b12198fc101d9
Gerrit-Change-Number: 56323
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Thu, 15 Jul 2021 09:37:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment