Attention is currently required from: Arthur Heymans, Jonathan Zhang, Johnny Lin, Christian Walter, David Hendricks, Stefan Reinauer, Edward O'Callaghan, Deomid "rojer" Ryabkov, Tim Chu. Hello Arthur Heymans, build bot (Jenkins), Jonathan Zhang, Johnny Lin, David Hendricks, Christian Walter, Stefan Reinauer, Edward O'Callaghan, David Hendricks, Deomid "rojer" Ryabkov, Tim Chu,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/flashrom/+/57589
to review the following change.
Change subject: Revert "Add support for Intel Emmitsburg PCH" ......................................................................
Revert "Add support for Intel Emmitsburg PCH"
This reverts commit 51e1d0e4b7670e5822560acc724a6a8dd00b6af4.
Breaks Ibex Peak descriptor detection.
Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a Signed-off-by: Nico Huber nico.h@gmx.de --- M chipset_enable.c M ich_descriptors.c 2 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/57589/1
diff --git a/chipset_enable.c b/chipset_enable.c index 110d7a9..cdd51ae 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -2073,7 +2073,6 @@ {0x8086, 0xa247, B_S, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa248, B_S, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa249, B_S, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, - {0x8086, 0x1bca, B_S, NT, "Intel", "Emmitsburg Chipset SKU", enable_flash_c620}, {0x8086, 0xa2c4, B_S, NT, "Intel", "H270", enable_flash_pch100}, {0x8086, 0xa2c5, B_S, NT, "Intel", "Z270", enable_flash_pch100}, {0x8086, 0xa2c6, B_S, NT, "Intel", "Q270", enable_flash_pch100}, diff --git a/ich_descriptors.c b/ich_descriptors.c index d56ade7..aba7528 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -939,8 +939,6 @@ warn_peculiar_desc(content->ISL != 23, "Gemini Lake"); return CHIPSET_GEMINI_LAKE; } - if (content->ISL <= 80) - return CHIPSET_C620_SERIES_LEWISBURG; warn_peculiar_desc(content->ISL != 16, "Ibex Peak"); return CHIPSET_5_SERIES_IBEX_PEAK; } else if (upper->MDTBA == 0x00) {