[flashrom-gerrit] Change in flashrom[master]: raiden_debug_spi.c: Clean up of the USB SPI protocol

[Brian Nemec (Code Review)]

Hello build bot (Jenkins), Brian Nemec, Edward O'Callaghan, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/41597

to look at the new patch set (#6).

Change subject: raiden_debug_spi.c: Clean up of the USB SPI protocol
......................................................................

raiden_debug_spi.c: Clean up of the USB SPI protocol

Perform some clean up of the USB SPI protocol 1 prior to adding
protocol 2 to improve consistency and correct minor issues.

* Minor clean up the comments descriptor for the protocol.
  This adds the location of another relevant file, corrects the
  omission of one of the protocol modes, makes the direction
  of the packets explicit, and minor formatting changes.

* Fix typos in constants associated with the retry mechanism.

* Clean declarations to match the EC code formats.

* Updates the error message formatting so protocol V1 closely
  matches the V2 protocol for consistency.

* Minor changes to the structure, moving validation of the
  arguments earlier in the transfer. Overall to keep V1 and
  V2 closer aligned and reduce future changes in the V1 code.

BUG=b:139058552
BRANCH=none
TEST=Builds

Signed-off-by: Brian J. Nemec 
Change-Id: I17e62dabee2724eecf8d5a1a7827f06f0c7514df
---
M raiden_debug_spi.c
1 file changed, 136 insertions(+), 65 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/41597/6