Attention is currently required from: Gaggery Tsai, Tim Crawford, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37677 )
Change subject: chipset_enable.c: Add CMP-H IDs
......................................................................
Patch Set 4:
(1 comment)
File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/37677/comment/61e68642_c6fd260d
PS2, Line 2050: {0x8086, 0x068d, B_S, NT, "Intel", "HM470", enable_flash_pch300},
: {0x8086, 0x068e, B_S, NT, "Intel", "WM490", enable_flash_pch300},
: {0x8086, 0x068c, B_S, NT, "Intel", "QM480", enable_flash_pch300},
: {0x8086, 0x0697, B_S, NT, "Intel", "W480", enable_flash_pch300},
: {0x8086, 0x0684, B_S, NT, "Intel", "H470", enable_flash_pch300},
: {0x8086, 0x0685, B_S, NT, "Intel", "Z490", enable_flash_pch300},
: {0x8086, 0x0687, B_S, NT, "Intel", "Q470", enable_flash_pch300},
Should the list be sorted after the ID?
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/37677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic7f04fc5cbe3422cbd219c46586c32fc847c921f
Gerrit-Change-Number: 37677
Gerrit-PatchSet: 4
Gerrit-Owner: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Duncan Laurie
duncan@iceblink.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 23 Apr 2021 00:22:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment