4 Jul
2019
4 Jul
'19
9:31 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33836 )
Change subject: flashchips: Drop dead code of AT26DF321 ......................................................................
Patch Set 10: Code-Review+2
(1 comment)
I know it's submitted already, but wanted to state that LGTM.
https://review.coreboot.org/c/flashrom/+/33836/9/flashchips.h File flashchips.h:
https://review.coreboot.org/c/flashrom/+/33836/9/flashchips.h@136 PS9, Line 136: /* Same as 26DF321 */
I intentionally left this comment here since it matches the comment on the AT25DF321 entry in flashc […]
Yep, that's perfectly fine.
--
To view, visit https://review.coreboot.org/c/flashrom/+/33836
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384
Gerrit-Change-Number: 33836
Gerrit-PatchSet: 10
Gerrit-Owner: Alan Green avg@google.com
Gerrit-Reviewer: Alan Green avg@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 04 Jul 2019 09:31:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Alan Green avg@google.com
Gerrit-MessageType: comment