Attention is currently required from: Nico Huber, Maciej Pijanowski, Angel Pons, Nikolai Artemiev, Sergii Dmytruk.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66212 )
Change subject: writeprotect_ranges.c: add more range functions ......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS3:
I'm afraid we will not be able to test all of them. […]
Maciej, thank you for response. So you tested on some chips but not all of them, is that correct? In this case, you definitely need to add the info in commit message, with the list of chips that you did test. Something like "tested at the end of a chain with chips A,B,C,...".
Also I talked with Nikolai on this topic and tldr: we currently don't have the chips you are adding, and can't help with testing. However if in future we get new devices with those chips we surely will test them.
The suggestion of
we might flag somehow the ones we tested and the ones which are purely based on the datasheet
is a good one but I think to do this in full we would need to implement: https://ticket.coreboot.org/issues/377
Meanwhile, maybe indicating in commit message will be fine. Angel, Nico, you are here, what are you thoughts on adding some of chips based on datasheets? Is it fine to add info in commit message.