Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39632 )
Change subject: ft2232_spi.c - change the chunksize from 256 to 270. ......................................................................
Patch Set 4:
Patch Set 4: Code-Review+1
This seems fine, however I wonder if it will be better to set the chunksize in ft2232_spi_send_command() where we have flash context and can tell if we're dealing with a large chip with a 4-byte address, since that will require adding another byte to the chunksize?
I am trying it out, it does seem to be faster (it might be placebo effect, though: didn't measure it accurately). I have to check if there's a struct we could use sizeof() on.