Attention is currently required from: Edward O'Callaghan, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72408 )
Change subject: dummyflasher: use new API to register shutdown function ......................................................................
Patch Set 2:
(1 comment)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/72408/comment/5b9de1af_4a670d17 PS2, Line 910: What if you try:
if (!emu_data) return 0;
The reason I thought about it, is that on first run of shutdown emu_data is freed. And then emu_data->anything is going to segfault right? emu_data is shared between masters if multiple are registered. hope I am not missing anything
The good thing about dummyflasher, it's [relatively] easy to add new unit tests for it. If there is any combination of buses that is not covered by unit test, it can be added, can be added in this patch. And then the best thing is: unit tests can fully test this patch! and unit tests are checking there is no memory leaks.