Paul Kocialkowski has posted comments on this change. ( https://review.coreboot.org/23260 )
Change subject: ENE EDI - add dummy read to ensure proper detection of ENE chips ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/23260/3/edi.c File edi.c:
https://review.coreboot.org/#/c/23260/3/edi.c@166 PS3, Line 166: static void edi_wakeup(struct flashctx *flash) Nico, I don't really agree here (sorry for the delay in replying): this is really not about waking up the chip but about the chip detecting that there is activity and enabling EDI. This is why "detect" felt like a good fit: the chip detects activity, but I agree that it's not very good since it can also be understood as "flashrom detecting the chip" which is not what's happening.
What about moving this read to edi_probe_kb9012 directly (under the comment block)? I guess it doesn't need its own function anyway.