[flashrom-gerrit] Change in flashrom[master]: ichspi.c: ich7_run_opcode() fail early on transact error

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46325 )

Change subject: ichspi.c: ich7_run_opcode() fail early on transact error
......................................................................

Patch Set 1: Code-Review-1
> Patch Set 1:
> > Also, the CDS timeout would be announced through either a an actual timeout or through FCERR aborting the loop. This cosmetic incorrectness is there with and without this patch.
> >
> > Overall I think the error message should distinguish between those two exit criteria, but (the rest of) this patch should be abandoned.
>
> And I should have kept reading. The code is actually already doing this correctly without any patch. So it should be fine to just abandon this, as it is a no-op as far as I can tell

Good point, thanks for noticing.