Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/82175?usp=email )
Change subject: flashrom: Change chip unlock error to warning ......................................................................
flashrom: Change chip unlock error to warning
Failing to disable WP before write/erase doesn't necessarily indicate an error and flashrom doesn't treat it as such. Print a warning instead on an error.
BUG=b:336220545 BRANCH=none TEST=build
Change-Id: I14c3b55e387443909ca1efab2fc1901f87dd66d6 Signed-off-by: Nikolai Artemiev nartemiev@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/82175 Reviewed-by: Hsuan-ting Chen roccochen@google.com Reviewed-by: Brian Norris briannorris@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Anastasia Klimchuk aklm@chromium.org --- M flashrom.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Nikolai Artemiev: Verified Brian Norris: Looks good to me, but someone else must approve Hsuan-ting Chen: Looks good to me, but someone else must approve build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved
diff --git a/flashrom.c b/flashrom.c index 6b15ee5..a365303 100644 --- a/flashrom.c +++ b/flashrom.c @@ -2092,7 +2092,7 @@
warn_out: if (ret) - msg_cerr("Failed to unlock flash status reg with wp support.\n"); + msg_cwarn("Failed to unlock flash status reg with wp support.\n");
return ret; }