Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57990 )
Change subject: custom_baud: move Linux specific code into own file ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File custom_baud.c:
https://review.coreboot.org/c/flashrom/+/57990/comment/bb0f618e_8eb8eadc PS3, Line 17: #include "custom_baud.h" I guess this was only on top because of the #if later. Generally <> includes should come first.
File custom_baud_linux.c:
https://review.coreboot.org/c/flashrom/+/57990/comment/1eb8722f_4ce046b6 PS3, Line 17: #include "custom_baud.h" Same here, please move blow the <> includes.