Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35480 )
Change subject: flashchips.c: Add GD25Q256D from downstream
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/35480/1/flashchips.c
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/35480/1/flashchips.c@6305
PS1, Line 6305: },
A non-NULL .printlock is needed?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/35480
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I79d4ed48aa9126a8a6ce455a9564451346195b8f
Gerrit-Change-Number: 35480
Gerrit-PatchSet: 1
Gerrit-Owner: Alan Green
avg@google.com
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 20 Sep 2019 05:38:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment