Attention is currently required from: Felix Singer, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68232 )
Change subject: rayer_spi.c: Drop lpt_outbyte intermediate var ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68232/comment/7fd77780_5dc48638 PS1, Line 9: itermediate
typo: i*n*termediate
Thank you, done.
File rayer_spi.c:
https://review.coreboot.org/c/flashrom/+/68232/comment/82b2cd7f_19815d4c PS1, Line 321: /* Get the initial value before writing to any line. */
I would rewrite or remove the comment. I don't understand it.
I didn't yet touch it as I didn't change the meaning of the code here. I think the comment is trying to say "get the initial iobase before writing out onto any hardware lines"?