Attention is currently required from: Felix Singer, Martin Roth, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62768 )
Change subject: flashrom.8.tmpl: Add raiden_debug_spi doc entry ......................................................................
Patch Set 4:
(4 comments)
Patchset:
PS4: Edward, it's nice that you want to document things. But please don't make the reviewers do all the work.
File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/62768/comment/064ed08c_b85c2e3b PS3, Line 1166: false
It was suggested in review to document like this, it actually works by matching "true" otherwise the […]
``` $ ./flashrom -p raiden_debug_spi:target=ap,custom_rst=false flashrom v1.2-682-gb94a5a21c on Linux 5.16.13-arch1-1 (x86_64) flashrom is free software, get the source code at https://flashrom.org
Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns). Invalid custom rst param: false Raiden target: -1 Error: Programmer initialization failed. ```
File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/62768/comment/04d0a182_3b1cd0e7 PS4, Line 1141: must be specified The code looks like it explicitly sends RAIDEN_DEBUG_SPI_REQ_ENABLE if no `target` was specified. What does it do? should it bail out instead?
https://review.coreboot.org/c/flashrom/+/62768/comment/594ad59e_c0a24642 PS4, Line 1168: parameter changes the timeout value from 3ms to 10ms. This is only applicable to `target=ap` AFAICS.