24 Jun
2020
24 Jun
'20
4:13 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36424 )
Change subject: sb600spi.c: Improve IMC runtime detection in handle_imc() ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/36424/5/sb600spi.c File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/36424/5/sb600spi.c@535 PS5, Line 535: AcpiMMIO
lower-case, please. e.g. […]
or `acpimmio`
--
To view, visit https://review.coreboot.org/c/flashrom/+/36424
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I13fb2300475c06aad09a4f0e8cd032e212556b14
Gerrit-Change-Number: 36424
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Daniel Kurtz djkurtz@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 24 Jun 2020 16:13:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment