Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39532 )
Change subject: flashchips: Add Macronix MX25R3235F
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
One last thing!
https://review.coreboot.org/c/flashrom/+/39532/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/39532/2//COMMIT_MSG@10
PS2, Line 10: halved.
This needs to go on the next line. The commit message width is at most 72 characters
https://review.coreboot.org/c/flashrom/+/39532/2//COMMIT_MSG@12
PS2, Line 12: working
Same here
--
To view, visit
https://review.coreboot.org/c/flashrom/+/39532
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6e79115adba17d13d24bc85d78707d53fd4a0be5
Gerrit-Change-Number: 39532
Gerrit-PatchSet: 2
Gerrit-Owner: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 23 Mar 2020 15:11:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment