Attention is currently required from: Balázs Vinarz.
Anastasia Klimchuk has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/flashrom/+/23053?usp=email )
Change subject: Fwd: Software info for Willem/EZOflash ......................................................................
Patch Set 1:
(1 comment)
This change is ready for review.
Patchset:
PS1:
wow, I just wondering if the old patchset (https://patchwork.coreboot.org/patch/1736/ https://mail. […]
Balázs, hello! I am so happy to see someone is interested in the old patch! I was planning to do an effort at some point (hopefully, a community effort) to sort the old patches, there is a lot of stuff from 2017-2022 which had no recent updates and the state is unclear. And now you come along and are adding a comment to one of the old patches!
Now, to the point of your question.
I can see the patch created in 2018 and there has never been any code review done. I can't comment on what and why was happening in 2018 because I wasn't here at that time.
To get this merged, we need to rebase on current head, complete a code review, test on hardware, and once all done and approved it can be merged (and add to release notes! :))
#1 Rebasing on the current head will be an effort. The code has changed since 6yr ago, enum programmer does not exist anymore, Makefile neither (it is meson.build now), flashrom.c had a lot of changes. Manpage is now generated from doc/classic_cli_manpage.rst. All of this is of course doable, but someone needs to do it.
#2 We need to find someone with hardware who is willing to test the patch after #1 is done.
#3 Patch needs to go through code reviews
#4 Optional but I would really like if someone agrees to be a maintainer for this new ezo programmer.
1, 2, 3, 4 doesn't have to be the same person
I can help with 1 and 3, and can't with 2 and 4
It seems you have an interest in the patch, what do you think you can help with? Do you know who has hardware and is willing to test? (maybe that's you?) Don't worry if you never did flashrom development before. Everyone had their very first patch once. What matters, we need to have people to cover 1, 2, 3, 4. Tell me what you think!
Also I am changing the status of the patch to Active (instead of Work In Progress) because Gerrit does not send emails for WIP patches, and it makes it hard to talk.