7 Apr
2022
7 Apr
'22
2:48 p.m.
Attention is currently required from: Jon Murphy, Edward O'Callaghan, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63422 )
Change subject: sb600spi.c: Use SPI100 bit mappings ......................................................................
Patch Set 1:
(1 comment)
File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/63422/comment/55bfef2f_0210fe91 PS1, Line 574: promontory_read_memmapped(
does this patch allow for this hack to be removed? […]
So this hack was added because reading using SPI commands is very slow compared to using the mmap. When using mmap, it does prefetching.
b/111800041#comment16
--
To view, visit https://review.coreboot.org/c/flashrom/+/63422
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If42130757331f4294b5a42c848557d3287f24fc3
Gerrit-Change-Number: 63422
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Robert Zieba robertzieba@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Karthikeyan Ramasubramanian kramasub@chromium.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Thu, 07 Apr 2022 14:48:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment