Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Victor Lim has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83012?usp=email )
Change subject: flashchips: Add support for chip model GD25LB128E/GD25LR128E ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/83012/comment/c015a44c_08b74aeb?usp... : PS1, Line 7: GD25LQ128E/GD25LB128E/GD25LR128E/GD25LQ128D/GD25LQ128C
You can replace this list with GD25LB128E/GD25LR128E , because you add two models, and the others we […]
Done
https://review.coreboot.org/c/flashrom/+/83012/comment/c3961701_0f048537?usp... : PS1, Line 9: Adding GD25LQ128E/GD25LB128E/GD25LR128E/GD25LQ128D/GD25LQ128C to flashchip.c : : These part # sharing the same ID, form, fit, function, produced with different process node: 1.8V 128Mbit
You need to wrap the commit message to be 72 chars max width. […]
Done