Attention is currently required from: Edward O'Callaghan, Daniel Campello.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62845 )
Change subject: tests: Add padding to pci_dev struct for ASAN
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62845/comment/01b143c6_58800b53
PS1, Line 58: FEATURES=test emerge-amd64-generic flashrom
Same as in the other patch: as a first line, it's better to have info how patch was tested in upstream tree. And then emerge with tests can be second line.
Patchset:
PS1:
Thank you so much for fixing a bug! I added this struct :\
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62845
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I47943bf70181a9041f287df3ece0f7067a112de8
Gerrit-Change-Number: 62845
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Comment-Date: Thu, 17 Mar 2022 23:11:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment