8 Oct
2019
8 Oct
'19
10:26 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35831 )
Change subject: flashrom: Add support for ARC platform ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/flashrom/+/35831/2/platform.h File platform.h:
https://review.coreboot.org/c/flashrom/+/35831/2/platform.h@130 PS2, Line 130: __arceb__ Hmmm, I can't find any reference for this (only Google results are this patch). But looking at other archs here, I assume that toolchain specific anyway and might have to be extended in the future.
It's definitely not wrong to assume BE in this case ^^ just wondering about false negatives.
--
To view, visit https://review.coreboot.org/c/flashrom/+/35831
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I88cbe74b716d5fab16133fbf2ce9c35b74c25f32
Gerrit-Change-Number: 35831
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 08 Oct 2019 10:26:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment