Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, David Hendricks, Edward O'Callaghan, Angel Pons.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57635 )
Change subject: Add support for Intel Emmitsburg PCH
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/57635/comment/8eab8fa1_b5f5ac99
PS1, Line 16: TESTED=tried on a server with Intel Emmitsburg PCH, flash update
: was successful. This server, however, does not have flash chip
: installed, it instead has em100 emulator connected.
I was able to run another round of tests on Archer City CRB with this patch chain and confirmed that […]
Done
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/57635/comment/22c6253a_6634ae01
PS3, Line 952: Ibex Peak is historically used as the default
Just because it was the newest mainstream platform on the `ICCRIBA == 0x00` path.
So if we add a newer chipset with `ICCRIBA == 0x00` and more straps then it should become the default? (ignoring the `FLMAP2 == 0` path)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57635
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1edae9163b910c3831adc82c90840fa965479451
Gerrit-Change-Number: 57635
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: David Hendricks
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Comment-Date: Sat, 18 Sep 2021 05:30:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Comment-In-Reply-To: David Hendricks
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment