8 Jun
2021
8 Jun
'21
7:16 a.m.
Attention is currently required from: Edward O'Callaghan, Arthur Heymans, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55266 )
Change subject: treewide: Drop most cases of `sizeof(struct ...)` ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55266/comment/f63bc2c8_9ba0532e PS1, Line 13: CONFIG_JLINK_SPI=no
why without jlink_spi?
Because it's the truth! 😄
Specifically, I used this exact command-line because I don't have libjaylink installed, and I'm not touching jlink_spi anyway.
--
To view, visit https://review.coreboot.org/c/flashrom/+/55266
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icc0b60ca6ef9f5ece6ed2a0e03600bb6ccd7dcc6
Gerrit-Change-Number: 55266
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Tue, 08 Jun 2021 14:16:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment