Hello Nico Huber,
I'd like you to do a code review. Please visit
https://review.coreboot.org/21886
to review the following change.
Change subject: squash! Convert flashrom to git ......................................................................
squash! Convert flashrom to git
Proposal for final commit message:
Convert flashrom to git
- Drop support for Subversion in the getrevision script and Makefile. - Refinement of getrevision to have a single function determining the new flashrom version string (based on git describe). - Add .gitignore and .gitattributes file (the latter to limit exports). - Restore modification dates of the exported files from the VCS. - Stop exporting VCS log dumps to CHANGELOG. This makes no sense. - Export VCS metadata needed by the Makefile to versioninfo.inc - Do not export the pre-"compiled" manpage. It can be generated like anything else from the code dump with versioninfo.inc - Add some initial client-side git hooks that get installed automatically on make runs: * pre-commit: - test for white space errors via git diff-index --check * commit-msg: - Use the up to date hook from gerrit to add Change-Id tags. Unlike the upstream hook, add them to fixup/squash changes too to allow for our staging process. - Test for duplicate sign-offs/acks. * When pushing to one of the upstream repositories check mandatory rules: - existing signoffs and acks in all new commits - no deletions of branches - no new branches other than versioned branches (e.g., 0.0.x) - no history rewriting of branches - Various other small refinements, bikesheddings and cosmetic changes to slow down progress of flashrom and humanity as a whole.
Original-Change-Id: I64eef21982cac0a0a7419bcd2c8a936672ae9cb2 Original-Reviewed-on: https://review.coreboot.org/19206 Original-Reviewed-by: Nico Huber nico.h@gmx.de Original-Reviewed-by: Philippe Mathieu-Daudé f4bug@amsat.org Original-Tested-by: build bot (Jenkins) no-reply@coreboot.org
Change-Id: I325edb7d9890c412a44ecacb5161268d3dbccc57 Signed-off-by: Stefan Tauner stefan.tauner@gmx.at Signed-off-by: David Hendricks dhendricks@fb.com Signed-off-by: Nico Huber nico.h@gmx.de --- I have included Nico in the sign-offs because of his contributions of bits of code in addition to his efforts to get things done and continuous reviews... and IMHO sign-offs should not only be stated for copyright- attainable code contributions but in any case if someone has direct involvement in making things possible... --- 0 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/21886/1