Attention is currently required from: Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52283 )
Change subject: linux_spi.c: Extract get_max_kernel_buf_size() as a function
......................................................................
Patch Set 1:
(1 comment)
File linux_spi.c:
https://review.coreboot.org/c/flashrom/+/52283/comment/10259c38_b3f69c12
PS1, Line 169: const uint8_t bits = 8;
Oh, I can explain why this line is not here. […]
Ack, my mistake thanks for pointing it out.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52283
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4b8c5775fb8f4b0dff702fcc0fb258221254c659
Gerrit-Change-Number: 52283
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Nikolai Artemiev
nartemiev@google.com
Gerrit-CC: Sam McNally
sammc@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Sun, 18 Apr 2021 12:14:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment