David Hendricks has posted comments on this change. ( https://review.coreboot.org/23021 )
Change subject: layout: Add -i <region>[:<file>] support. ......................................................................
Patch Set 4:
(3 comments)
Almost there...
https://review.coreboot.org/#/c/23021/4/flashrom.c File flashrom.c:
https://review.coreboot.org/#/c/23021/4/flashrom.c@1400 PS4, Line 1400: if( nit: add a space between if and open paren
https://review.coreboot.org/#/c/23021/4/layout.c File layout.c:
https://review.coreboot.org/#/c/23021/4/layout.c@270 PS4, Line 270: goto out; Perhaps it will be more useful to just keep going here so that the user knows all of the regions which overlap.
https://review.coreboot.org/#/c/23021/4/layout.c@272 PS4, Line 272: extra line?