Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48133 )
Change subject: ichspi.c: Implement ich_hwseq_get_flash_id()
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
https://review.coreboot.org/c/flashrom/+/48133/1/ichspi.c
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/48133/1/ichspi.c@1375
PS1, Line 1375: ich_read_data((uint8_t *)&data, len, ICH9_REG_FDATA0);
Hey Arthur, that's very weird. […]
Thanks! That's very helpful and thanks for taking the time to help test!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/48133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icdf684e21b19ee87b797092f3cf0353e1184291f
Gerrit-Change-Number: 48133
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Stefan Reinauer
reinauer@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 30 Nov 2020 09:10:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment