David Hendricks has posted comments on this change. ( https://review.coreboot.org/22383 )
Change subject: spi25: Use common code for nbyte read/write and block erase
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Very minor spelling error, otherwise LGTM.
https://review.coreboot.org/#/c/22383/1/spi25.c
File spi25.c:
https://review.coreboot.org/#/c/22383/1/spi25.c@326
PS1, Line 326: spi_poll_wip
Thanks for updating this.
https://review.coreboot.org/#/c/22383/1/spi25.c@384
PS1, Line 384: iff
if
--
To view, visit
https://review.coreboot.org/22383
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1ae48acbfbd427a30bcd64bdc080dc3dc20503
Gerrit-Change-Number: 22383
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 13 Nov 2017 01:24:12 +0000
Gerrit-HasComments: Yes