[flashrom-gerrit] Change in flashrom[master]: it85spi.c: Refactor singleton states into reentrant pattern

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47655 )

Change subject: it85spi.c: Refactor singleton states into reentrant pattern
......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/flashrom/+/47655/4/it85spi.c 
File it85spi.c:

https://review.coreboot.org/c/flashrom/+/47655/4/it85spi.c@250 
PS4, Line 250:         unsigned int i;
             : 
             :         struct it85spi_data *data;
keep the declarations together. So

```
unsigned int i;
struct it85spi_data *data;

if (get_data_from_context(flash, &data) < 0) {
..
```

https://review.coreboot.org/c/flashrom/+/47655/4/it85spi.c@318 
PS4, Line 318:         data->ce_high = 0;
             :         data->ce_low = 0;
```
        data->ce_high = NULL;
        data->ce_low = NULL;
```

https://review.coreboot.org/c/flashrom/+/47655/4/it85spi.c@326 
PS4, Line 326: {
             : 		return 1;
`free(data);` before the return, it was correct before.