Attention is currently required from: Nico Huber, Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62833 )
Change subject: print_buildinfo: remove unreachable print of libpci version
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Why not include the header instead?
It would make the build more complex. Especially if you want to unify the behavior for all libraries.
As alternative a build time generated struct with those information may me a good solution. Then there would be no need to include header files.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62833
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382
Gerrit-Change-Number: 62833
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 15 Mar 2022 15:40:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment