Attention is currently required from: Angel Pons, Artur Kowalski.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68557?usp=email )
Change subject: flashchips: add support for MX77L25650F chip
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
A thread on the mailing list adding the same chip: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/ZVRE6...
There are more erasers on the ml, what's in the datasheet?
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/68557/comment/dd2548c0_390bc809 :
PS4, Line 10428: .vendor = "Macronix",
The values need to be tab-aligned, see the other entries.
https://review.coreboot.org/c/flashrom/+/68557/comment/646d2836_055d979b :
PS4, Line 10452: },
The voltage is missing?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/68557?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iaea5485f8b59b8538dc47beada2c308376ea027c
Gerrit-Change-Number: 68557
Gerrit-PatchSet: 4
Gerrit-Owner: Artur Kowalski
artur.kowalski@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Artur Kowalski
arturkow2000@gmail.com
Gerrit-Attention: Artur Kowalski
artur.kowalski@3mdeb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 16 Jun 2023 11:17:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment