Attention is currently required from: Felix Singer, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63826 )
Change subject: meson: use `platform/` as subdir()
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File meson.build:
https://review.coreboot.org/c/flashrom/+/63826/comment/76755d72_ec06ced6
PS2, Line 80: host_is_x86 = ['x86', 'x86_64'].contains(host_machine.cpu_family())
Is the single sentence enough?
Yes, thanks!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63826
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I88044a3f903f316138483dd872a6d95f8686ae69
Gerrit-Change-Number: 63826
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Thu, 05 May 2022 05:34:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment