Mario Limonciello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35566 )
Change subject: meson.build: Sanitize the version string
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/flashrom/+/35566/2/meson.build
File meson.build:
https://review.coreboot.org/c/flashrom/+/35566/2/meson.build@360
PS2, Line 360: #strip dirty version info
Unconditionally stripping a -dirty defeats the purpose of a -dirty. […]
Well some projects automatically bump version to something newer as the first commit after release. That's one way to "fix" it.
I certainly agree there is value to this version information.
I guess let's run with no dash stripping for now and see who complains and go from there. I'll adjust this CL.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/35566
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I25587ed2ad7fbcffdf14eb758c1f0d6ab2aea545
Gerrit-Change-Number: 35566
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Limonciello
superm1@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Mario Limonciello
superm1@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Oct 2019 14:00:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Limonciello
superm1@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment