Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64375 )
Change subject: writeprotect.c: Allow opaque masters to hook spi_{rw}_register()
......................................................................
Patch Set 6:
(1 comment)
File include/programmer.h:
https://review.coreboot.org/c/flashrom/+/64375/comment/b2805ef9_e950968d
PS6, Line 405: int (*read_register)(const struct flashctx *flash, enum flash_reg reg, uint8_t *value);
: int (*write_register)(const struct flashctx *flash, enum flash_reg reg, uint8_t value);
If these are meant to stay WP only, they should have "wp_" prefix.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64375
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3ab0d7f5f48338c8ecb118a69651c203fbc516ac
Gerrit-Change-Number: 64375
Gerrit-PatchSet: 6
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Sun, 29 May 2022 13:18:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment