20 May
2023
20 May
'23
9:31 a.m.
Attention is currently required from: Thomas Heijligen, Angel Pons, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75271 )
Change subject: chipset_enable.c: Drop `_LARGEFILE64_SOURCE` ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Also see Nico's comment on CB:75272 […]
Thanks Angel for explanation. Commit link doesn't work, but I believe you that commit does what you are saying :)
Is that the case for this patch, that the binary should be the same before and after?
--
To view, visit https://review.coreboot.org/c/flashrom/+/75271
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I866cfa2f996eeea5846e5d9189647ad7a4a4e3e4
Gerrit-Change-Number: 75271
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Alexander Goncharov chat@joursoir.net
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Alexander Goncharov chat@joursoir.net
Gerrit-Comment-Date: Sat, 20 May 2023 09:31:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Comment-In-Reply-To: Alexander Goncharov chat@joursoir.net
Gerrit-MessageType: comment