Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69268 )
Change subject: tests: Add llvm-cov option and run target for code coverage
......................................................................
Patch Set 9:
(2 comments)
File meson.build:
https://review.coreboot.org/c/flashrom/+/69268/comment/bff36be2_eec15379
PS5, Line 534: if get_option('llvm_cov')
Also need to check that tests feature is enabled
coverage can be used independently of unit tests
File meson_options.txt:
https://review.coreboot.org/c/flashrom/+/69268/comment/a0029578_f31bbc9d
PS5, Line 19: type : 'boolean'
I think this should be a feature, like unit tests themselves. […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69268
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id6c73bff46e7b88d425956a80def97082b201f56
Gerrit-Change-Number: 69268
Gerrit-PatchSet: 9
Gerrit-Owner: Evan Benn
evanbenn@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 14 Nov 2022 00:31:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment